netdev - Re: [PATCH] net: cxgb3: add missed destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23c0e185-5897-c6d0-1db7-b9ffa3df44ec@huawei.com>
Date:   Sat, 18 Jul 2020 15:57:13 +0800
From:   "wanghai (M)" <wanghai38@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <vishal@...lsio.com>, <kuba@...nel.org>, <jeff@...zik.org>,
        <divy@...lsio.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe
 failure


在 2020/7/18 9:39, David Miller 写道:
> From: Wang Hai <wanghai38@...wei.com>
> Date: Fri, 17 Jul 2020 14:21:17 +0800
>
>> The driver forgets to call destroy_workqueue when cxgb3 probe fails.
>> Add the missed calls to fix it.
>>
>> Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.")
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> You have to handle the case that the probing of one or more devices
> fails yet one or more others succeed.
>
> And you can't know in advance how this will play out.
>
> This is why the workqueue is unconditionally created, and only destroyed
> on module remove.
>
> .
Thanks for your explanation. I got it.