netdev - Re: [PATCH] net: dsa: felix: Make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dea3b332-8af7-b8db-6182-702b91ceeae4@huawei.com>
Date:   Sat, 18 Jul 2020 18:49:10 +0800
From:   "wanghai (M)" <wanghai38@...wei.com>
To:     Vladimir Oltean <olteanv@...il.com>
CC:     <UNGLinuxDriver@...rochip.com>, <vladimir.oltean@....com>,
        <claudiu.manoil@....com>, <alexandre.belloni@...tlin.com>,
        <andrew@...n.ch>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: felix: Make some symbols static

Thanks for reminding me, I'll do it.

在 2020/7/18 18:40, Vladimir Oltean 写道:
> On Sat, Jul 18, 2020 at 06:01:58PM +0800, Wang Hai wrote:
>> Fix sparse build warning:
>>
>> drivers/net/dsa/ocelot/felix_vsc9959.c:560:19: warning:
>>   symbol 'vsc9959_vcap_is2_keys' was not declared. Should it be static?
>> drivers/net/dsa/ocelot/felix_vsc9959.c:640:19: warning:
>>   symbol 'vsc9959_vcap_is2_actions' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Wang Hai <wanghai38@...wei.com>
>> ---
> Please update your tree.
>
> commit 3ab4ceb6e9639e4e42d473e46ae7976c24187876
> Author: Vladimir Oltean <vladimir.oltean@....com>
> Date:   Sat Jun 20 18:43:36 2020 +0300
>
>      net: dsa: felix: make vcap is2 keys and actions static
>
>      Get rid of some sparse warnings.
>
>      Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
>      Signed-off-by: David S. Miller <davem@...emloft.net>
>
>>   drivers/net/dsa/ocelot/felix_vsc9959.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c
>> index 1dd9e348152d..2067776773f7 100644
>> --- a/drivers/net/dsa/ocelot/felix_vsc9959.c
>> +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c
>> @@ -557,7 +557,7 @@ static const struct ocelot_stat_layout vsc9959_stats_layout[] = {
>>   	{ .offset = 0x111,	.name = "drop_green_prio_7", },
>>   };
>>   
>> -struct vcap_field vsc9959_vcap_is2_keys[] = {
>> +static struct vcap_field vsc9959_vcap_is2_keys[] = {
>>   	/* Common: 41 bits */
>>   	[VCAP_IS2_TYPE]				= {  0,   4},
>>   	[VCAP_IS2_HK_FIRST]			= {  4,   1},
>> @@ -637,7 +637,7 @@ struct vcap_field vsc9959_vcap_is2_keys[] = {
>>   	[VCAP_IS2_HK_OAM_IS_Y1731]		= {182,   1},
>>   };
>>   
>> -struct vcap_field vsc9959_vcap_is2_actions[] = {
>> +static struct vcap_field vsc9959_vcap_is2_actions[] = {
>>   	[VCAP_IS2_ACT_HIT_ME_ONCE]		= {  0,  1},
>>   	[VCAP_IS2_ACT_CPU_COPY_ENA]		= {  1,  1},
>>   	[VCAP_IS2_ACT_CPU_QU_NUM]		= {  2,  3},
>> -- 
>> 2.17.1
>>
> Thanks,
> -Vladimir
>
> .
>