netdev - Re: [PATCH net-next 0/3] Document more PTP timestamping known quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878sfh132m.fsf@osv.gnss.ru>
Date:   Sat, 18 Jul 2020 14:21:21 +0300
From:   Sergey Organov <sorganov@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org,
        richardcochran@...il.com, linux-doc@...r.kernel.org,
        Eugene Syromiatnikov <esyr@...hat.com>
Subject: Re: [PATCH net-next 0/3] Document more PTP timestamping known quirks

Vladimir Oltean <olteanv@...il.com> writes:

> I've tried to collect and summarize the conclusions of these discussions:
> https://patchwork.ozlabs.org/project/netdev/patch/20200711120842.2631-1-sorganov@gmail.com/
> https://patchwork.ozlabs.org/project/netdev/patch/20200710113611.3398-5-kurt@linutronix.de/
> which were a bit surprising to me. Make sure they are present in the
> documentation.

By the way, there is another somewhat related issue that needs to be
addressed. I believe kernel needs to free user space from this trick
found even in kernel sources themselves:

tools/testing/selftests/ptp/testptp.c:87:

static clockid_t get_clockid(int fd)
{
#define CLOCKFD 3
        return (((unsigned int) ~fd) << 3) | CLOCKFD;
}

Once upon a time there was a patch for that, but I don't think it
addressed the issue correctly, here is more background:

https://lore.kernel.org/lkml/87y2pxvsbr.fsf@osv.gnss.ru/

Thanks,
-- Sergey