netdev - Re: [PATCH net-next] net: bnxt: don't complain if TC flower can't be supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200717.182632.384224926082494030.davem@davemloft.net>
Date:   Fri, 17 Jul 2020 18:26:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuba@...nel.org
Cc:     netdev@...r.kernel.org, kernel-team@...com,
        michael.chan@...adcom.com
Subject: Re: [PATCH net-next] net: bnxt: don't complain if TC flower can't
 be supported

From: Jakub Kicinski <kuba@...nel.org>
Date: Fri, 17 Jul 2020 13:59:58 -0700

> The fact that NETIF_F_HW_TC is not set should be a sufficient
> indication to the user that TC offloads are not supported.
> No need to bother users of older firmware versions with
> pointless warnings on every boot.
> 
> Also, since the support is optional, bnxt_init_tc() should not
> return an error in case FW is old, similarly to how error
> is not returned when CONFIG_BNXT_FLOWER_OFFLOAD is not set.
> 
> With that we can add an error message to the caller, to warn
> about actual unexpected failures.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Applied, thank you.