netdev - Re: [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200719152723.GG1383417@lunn.ch>
Date:   Sun, 19 Jul 2020 17:27:23 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Martin Rowe <martin.p.rowe@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org,
        Gregory Clement <gregory.clement@...tlin.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Jason Cooper <jason@...edaemon.net>,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net] arm64: dts: clearfog-gt-8k: fix switch link
 configuration

On Sun, Jul 19, 2020 at 12:00:40PM +0100, Russell King wrote:
> The commit below caused a regression for clearfog-gt-8k, where the link
> between the switch and the host does not come up.
> 
> Investigation revealed two issues:
> - MV88E6xxx DSA no longer allows an in-band link to come up as the link
>   is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix
>   in-band AN link establishment" addresses this.
> 
> - The dts configured dissimilar link modes at each end of the host to
>   switch link; the host was configured using a fixed link (so has no
>   in-band status) and the switch was configured to expect in-band
>   status.
> 
> With both issues fixed, the regression is resolved.
> 
> Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link")
> Reported-by: Martin Rowe <martin.p.rowe@...il.com>
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew