netdev - Re: [PATCH net v2] bonding: check error value of register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Jul 2020 18:13:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     kuba@...nel.org, j.vosburgh@...il.com, vfalico@...il.com,
        andy@...yhouse.net, netdev@...r.kernel.org,
        xiyou.wangcong@...il.com, kernel@...uxace.com
Subject: Re: [PATCH net v2] bonding: check error value of
 register_netdevice() immediately

From: Taehee Yoo <ap420073@...il.com>
Date: Sun, 19 Jul 2020 12:11:24 +0000

> If register_netdevice() is failed, net_device should not be used
> because variables are uninitialized or freed.
> So, the routine should be stopped immediately.
> But, bond_create() doesn't check return value of register_netdevice()
> immediately. That will result in a panic because of using uninitialized
> or freed memory.
> 
> Test commands:
>     modprobe netdev-notifier-error-inject
>     echo -22 > /sys/kernel/debug/notifier-error-inject/netdev/\
> actions/NETDEV_REGISTER/error
>     modprobe bonding max_bonds=3
> 
> Splat looks like:
 ...
> Fixes: e826eafa65c6 ("bonding: Call netif_carrier_off after register_netdevice")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied and queued up for -stable, thank you.