netdev - Re: [PATCH bpf-next v3 04/14] xsk: move fill and completion rings to buffer pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ8uoz1ReofjQQRpqKa80P1L93SRsdAPPLcEJsuaOpXzq5_=yg@mail.gmail.com>
Date:   Mon, 20 Jul 2020 15:23:26 +0200
From:   Magnus Karlsson <magnus.karlsson@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Magnus Karlsson <magnus.karlsson@...el.com>,
        Björn Töpel <bjorn.topel@...el.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Maxim Mikityanskiy <maximmi@...lanox.com>,
        kbuild-all@...ts.01.org, bpf <bpf@...r.kernel.org>,
        jeffrey.t.kirsher@...el.com, anthony.l.nguyen@...el.com
Subject: Re: [PATCH bpf-next v3 04/14] xsk: move fill and completion rings to
 buffer pool

On Mon, Jul 20, 2020 at 2:21 PM kernel test robot <lkp@...el.com> wrote:
>
> Hi Magnus,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on bpf-next/master]
>
> url:    https://github.com/0day-ci/linux/commits/Magnus-Karlsson/xsk-support-shared-umems-between-devices-and-queues/20200720-180143
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> config: alpha-allmodconfig (attached as .config)
> compiler: alpha-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All errors (new ones prefixed by >>):
>
>    net/xdp/xsk_diag.c: In function 'xsk_diag_put_stats':
> >> net/xdp/xsk_diag.c:88:70: error: 'struct xdp_umem' has no member named 'fq'
>       88 |  du.n_fill_ring_empty = xs->umem ? xskq_nb_queue_empty_descs(xs->umem->fq) : 0;
>          |                                                                      ^~

Thank you Mr LKP robot. Yes, bisectability is broken in patch 3. Will spin a v4.

/Magnus

> vim +88 net/xdp/xsk_diag.c
>
> a36b38aa2af611 Björn Töpel  2019-01-24  80
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  81  static int xsk_diag_put_stats(const struct xdp_sock *xs, struct sk_buff *nlskb)
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  82  {
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  83      struct xdp_diag_stats du = {};
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  84
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  85      du.n_rx_dropped = xs->rx_dropped;
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  86      du.n_rx_invalid = xskq_nb_invalid_descs(xs->rx);
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  87      du.n_rx_full = xs->rx_queue_full;
> 0d80cb4612aa32 Ciara Loftus 2020-07-08 @88      du.n_fill_ring_empty = xs->umem ? xskq_nb_queue_empty_descs(xs->umem->fq) : 0;
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  89      du.n_tx_invalid = xskq_nb_invalid_descs(xs->tx);
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  90      du.n_tx_ring_empty = xskq_nb_queue_empty_descs(xs->tx);
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  91      return nla_put(nlskb, XDP_DIAG_STATS, sizeof(du), &du);
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  92  }
> 0d80cb4612aa32 Ciara Loftus 2020-07-08  93
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org