netdev - Re: [PATCH v2 net-next 01/14] qed: convert link mode from u32 to bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de4b0ef6b1b7b58acc184d1d7e80456f6c3b56c0.camel@perches.com>
Date:   Mon, 20 Jul 2020 08:19:52 -0700
From:   Joe Perches <joe@...ches.com>
To:     Alexander Lobakin <alobakin@...vell.com>,
        Andrew Lunn <andrew@...n.ch>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Igor Russkikh <irusskikh@...vell.com>,
        Michal Kalderon <michal.kalderon@...vell.com>,
        Ariel Elior <aelior@...vell.com>,
        Denis Bolotin <denis.bolotin@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        GR-everest-linux-l2@...vell.com,
        QLogic-Storage-Upstream@...vell.com, netdev@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next 01/14] qed: convert link mode from u32 to
 bitmap

On Mon, 2020-07-20 at 12:23 +0300, Alexander Lobakin wrote:
> Date: Sun, 19 Jul 2020 23:21:00 +0200 From: Andrew Lunn <andrew@...n.ch>
> > On Sun, Jul 19, 2020 at 11:14:40PM +0300, Alexander Lobakin wrote:
> > > Currently qed driver already ran out of 32 bits to store link modes,
> > > and this doesn't allow to add and support more speeds.
> > > Convert link mode to bitmap that will always have enough space for
> > > any number of speeds and modes.
[]
> > Why not just throw away all these QED_LM_ defines and use the kernel
> > link modes? The fact you are changing the u32 to a bitmap suggests the
> > hardware does not use them.
> 
> I've just double-checked, and you're right, management firmware operates
> with NVM_* definitions, while QED_LM_* are used only in QED and QEDE to
> fill Ethtool link settings.
> I didn't notice this while working on the series, but it would be really
> a lot better to just use generic definitions.
> So I'll send v3 soon.

While you're at it, why are you using __set_bit and not set_bit?