lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jul 2020 09:57:01 +0800 From: Bixuan Cui <cuibixuan@...wei.com> To: Stephen Hemminger <stephen@...workplumber.org> CC: <davem@...emloft.net>, <kuba@...nel.org>, <linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <jdmason@...zu.us>, <christophe.jaillet@...adoo.fr>, <john.wanghui@...wei.com> Subject: Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX On 2020/7/20 1:05, Stephen Hemminger wrote: > On Thu, 16 Jul 2020 17:32:47 +0000 > Bixuan Cui <cuibixuan@...wei.com> wrote: > >> Fix the warning: [-Werror=-Wframe-larger-than=] >> >> drivers/net/ethernet/neterion/vxge/vxge-main.c: >> In function'VXGE_COMPLETE_VPATH_TX.isra.37': >> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: >> warning: the frame size of 1056 bytes is larger than 1024 bytes >> >> Signed-off-by: Bixuan Cui <cuibixuan@...wei.com> > Dropping the NR_SKB_COMPLETED to 16 won't have much impact > on performance, and shrink the size. > > Doing 16 skb's at a time instead of 128 probably costs > less than one allocation. Especially since it is unlikely > that the device completed that many transmits at once. > > I will send the v2 patch based on your suggestions. thanks
Powered by blists - more mailing lists