lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jul 2020 10:24:43 -0700 From: Stephen Hemminger <stephen@...workplumber.org> To: Chi Song <chisong@...ux.microsoft.com> Cc: "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Stephen Hemminger <sthemmin@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, linux-hyperv@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 net-next] net: hyperv: Add attributes to show TX indirection table On Mon, 20 Jul 2020 00:12:10 -0700 (PDT) Chi Song <chisong@...ux.microsoft.com> wrote: > An imbalanced TX indirection table causes netvsc to have low > performance. This table is created and managed during runtime. To help > better diagnose performance issues caused by imbalanced tables, add > device attributes to show the content of TX indirection tables. > > Signed-off-by: Chi Song <chisong@...rosoft.com> > --- > v2: remove RX as it's in ethtool already, show single value in each file, > and update description. > > Thank you for comments. Let me know, if I miss something. > > --- > drivers/net/hyperv/netvsc_drv.c | 53 +++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/drivers/net/hyperv/netvsc_drv.c > b/drivers/net/hyperv/netvsc_drv.c > index 6267f706e8ee..222c2fad9300 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -2370,6 +2370,55 @@ static int netvsc_unregister_vf(struct net_device > *vf_netdev) > return NOTIFY_OK; > } > > +static struct device_attribute > dev_attr_netvsc_dev_attrs[VRSS_SEND_TAB_SIZE]; > +static struct attribute *netvsc_dev_attrs[VRSS_SEND_TAB_SIZE + 1]; > + > +const struct attribute_group netvsc_dev_group = { > + .name = NULL, > + .attrs = netvsc_dev_attrs, > +}; > + > +static ssize_t tx_indirection_table_show(struct device *dev, > + struct device_attribute > *dev_attr, > + char *buf) > +{ > + struct net_device *ndev = to_net_dev(dev); > + struct net_device_context *ndc = netdev_priv(ndev); > + ssize_t offset = 0; useless initialization > + int index = dev_attr - dev_attr_netvsc_dev_attrs; > + > + offset = sprintf(buf, "%u\n", ndc->tx_table[index]); > + > + return offset; why not just return sprintf(buf, "%u\n", ndc->tx_table[index]); > +} > + > +static void netvsc_attrs_init(void) > +{ > + int i; > + char buffer[32]; > + > + for (i = 0; i < VRSS_SEND_TAB_SIZE; i++) { > + sprintf(buffer, "tx_indirection_table_%02u", i); Although this has one value per file it leads to a mess. Why not put it in a separate directory (/sys/class/net/eth0/tx_indirection/N)?
Powered by blists - more mailing lists