netdev - Re: [PATCH v2 0/2 net] bitfield.h cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdkGmgdh6-4VRUGkd1KRC-PgFcGwP5vKJvO9Oj3cB_Qh6Q@mail.gmail.com>
Date:   Mon, 20 Jul 2020 12:48:38 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     "David S . Miller" <davem@...emloft.net>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>, oss-drivers@...ronome.com,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>, Alex Elder <elder@...aro.org>
Subject: Re: [PATCH v2 0/2 net] bitfield.h cleanups

On Tue, Jul 14, 2020 at 11:23 AM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> On Wed, Jul 8, 2020 at 4:04 PM Nick Desaulniers <ndesaulniers@...gle.com> wrote:
> >
> > Two patches, one that removes a BUILD_BUG_ON for a case that is not a
> > compile time bug (exposed by compiler optimization).
> >
> > The second is a general cleanup in the area.
> >
> > I decided to leave the BUILD_BUG_ON case first, as I hope it will
> > simplify being able to backport it to stable, and because I don't think
> > there's any type promotion+conversion bugs there.
> >
> > Though it would be nice to use consistent types widths and signedness,
> > equality against literal zero is not an issue.
> >
> > Jakub Kicinski (1):
> >   bitfield.h: don't compile-time validate _val in FIELD_FIT
> >
> > Nick Desaulniers (1):
> >   bitfield.h: split up __BF_FIELD_CHECK macro
> >
> >  .../netronome/nfp/nfpcore/nfp_nsp_eth.c       | 11 ++++----
> >  include/linux/bitfield.h                      | 26 +++++++++++++------
> >  2 files changed, 24 insertions(+), 13 deletions(-)
> >
> > --
> > 2.27.0.383.g050319c2ae-goog
> >
>
> Hey David, when you have a chance, could you please consider picking
> up this series?
> --

Hi David, bumping for review.
-- 
Thanks,
~Nick Desaulniers