netdev - Re: [PATCH ethtool v3 1/2] ethtool: add support for get/set ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200720213022.rp42exbfdiqtwle4@lion.mk-sys.cz>
Date:   Mon, 20 Jul 2020 23:30:22 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Govindarajulu Varadarajan <gvaradar@...co.com>
Cc:     netdev@...r.kernel.org, edumazet@...gle.com,
        linville@...driver.com, govind.varadar@...il.com, benve@...co.com
Subject: Re: [PATCH ethtool v3 1/2] ethtool: add support for get/set
 ethtool_tunable

On Sun, Jul 19, 2020 at 04:59:27PM -0700, Govindarajulu Varadarajan wrote:
> Add support for ETHTOOL_GTUNABLE and ETHTOOL_STUNABLE options.
> 
> Tested rx-copybreak on enic driver. Tested ETHTOOL_TUNABLE_STRING
> options with test/debug changes in kernel.
> 
> Signed-off-by: Govindarajulu Varadarajan <gvaradar@...co.com>
> ---
> v3:
> * Remove handling of string type tunables
> 
> v2:
> * Fix alignments and braces.
> * Move union definition outside struct.
> * Make seen type int.
> * Use uniform C90 types in union.
> * Remove NULL assignment and memset to 0.
> * Change variable name from tinfo to tunables_info.
> * Use ethtool_tunable_info_val in print_tunable()
> * Remove one-letter command line option.
> * Use PRI* for int type in print_tunable().

Applied both patches, thank you.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)