netdev - Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200720.162726.1756372964350832473.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 16:27:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     srirakr2@...co.com
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, mbumgard@...co.com, ugm@...co.com,
        nimm@...co.com, xe-linux-external@...co.com, kuba@...nel.org,
        linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

From: Sriram Krishnan <srirakr2@...co.com>
Date: Mon, 20 Jul 2020 22:15:51 +0530

> +	if (skb->protocol == htons(ETH_P_8021Q)) {
> +		u16 vlan_tci = 0;
> +		skb_reset_mac_header(skb);

Please place an empty line between basic block local variable declarations
and actual code.

> +				netdev_err(net,"Pop vlan err %x\n",pop_err);

A space is necessary before "pop_err".