netdev - Re: [PATCH ethtool] Fix segfault with cable test and ./configure --disable-netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200720003111.GN1383417@lunn.ch>
Date:   Mon, 20 Jul 2020 02:31:11 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev <netdev@...r.kernel.org>, Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH ethtool] Fix segfault with cable test and ./configure
 --disable-netlink

On Mon, Jul 20, 2020 at 02:12:51AM +0200, Michal Kubecek wrote:
> On Fri, Jul 17, 2020 at 12:05:09AM +0200, Andrew Lunn wrote:
> > When the netlink interface code is disabled, a stub version of
> > netlink_run_handler() is used. This stub version needs to handle the
> > case when there is no possibility for a command to fall back to the
> > IOCTL call. The two cable tests commands have no such fallback, and if
> > we don't handle this, ethtool tries to jump through a NULL pointer
> > resulting in a segfault.
> > 
> > Reported-by: Chris Healy <cphealy@...il.com>
> > Signed-off-by: Andrew Lunn <andrew@...n.ch>
> 
> Applied, thank you. I'll need to be more thorough with teseting the
> --disable-netlink builds.

Hi Michal

Yes. We are all focused on retlink, and missed the backwards
compatibility issues like this.

      Andrew