lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Jul 2020 10:35:25 +0200 From: Stefan Schmidt <stefan@...enfreihafen.org> To: Liu Jian <liujian56@...wei.com>, h.morris@...coda.com, alex.aring@...il.com, davem@...emloft.net, kuba@...nel.org, marcel@...tmann.or, netdev@...r.kernel.org Subject: Re: [PATCH net] ieee802154: fix one possible memleak in ca8210_dev_com_init Hello. On 20.07.20 16:33, Liu Jian wrote: > We should call destroy_workqueue to destroy mlme_workqueue in error branch. > > Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") > Signed-off-by: Liu Jian <liujian56@...wei.com> > --- > drivers/net/ieee802154/ca8210.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c > index e04c3b60cae7..4eb64709d44c 100644 > --- a/drivers/net/ieee802154/ca8210.c > +++ b/drivers/net/ieee802154/ca8210.c > @@ -2925,6 +2925,7 @@ static int ca8210_dev_com_init(struct ca8210_priv *priv) > ); > if (!priv->irq_workqueue) { > dev_crit(&priv->spi->dev, "alloc of irq_workqueue failed!\n"); > + destroy_workqueue(priv->mlme_workqueue); > return -ENOMEM; > } For ieee802154 patches please keep the linux-wpan list in CC. This allows me to track patches with patchwork. Applied this one manually. This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt
Powered by blists - more mailing lists