netdev - Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200721133655.GA1472201@lunn.ch>
Date:   Tue, 21 Jul 2020 15:36:55 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        nicolas.ferre@...rochip.com, claudiu.beznea@...rochip.com,
        davem@...emloft.net, kuba@...nel.org, f.fainelli@...il.com,
        robh+dt@...nel.org, alexandre.belloni@...tlin.com,
        ludovic.desroches@...rochip.com
Subject: Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an
 MDIO node

> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp)
>  			 * decrement it before returning.
>  			 */
>  			of_node_put(child);
> -
>  			return of_mdiobus_register(bp->mii_bus, np);
>  		}

Please avoid white space changes like this.

Otherwise this looks O.K.

       Andrew