netdev - Re: [PATCH bpf-next] bpf, netns: Fix build without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+F3devpvOg7i6td99Hq3bXOVe0t6_tUKnFzw-=v6Ky9A@mail.gmail.com>
Date:   Tue, 21 Jul 2020 09:14:25 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Jakub Sitnicki <jakub@...udflare.com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        kernel-team <kernel-team@...udflare.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH bpf-next] bpf, netns: Fix build without CONFIG_INET

On Tue, Jul 21, 2020 at 7:01 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 7/21/20 3:07 AM, Jakub Sitnicki wrote:
> > When CONFIG_NET is set but CONFIG_INET isn't, build fails with:
> >
> >   ld: kernel/bpf/net_namespace.o: in function `netns_bpf_attach_type_unneed':
> >   kernel/bpf/net_namespace.c:32: undefined reference to `bpf_sk_lookup_enabled'
> >   ld: kernel/bpf/net_namespace.o: in function `netns_bpf_attach_type_need':
> >   kernel/bpf/net_namespace.c:43: undefined reference to `bpf_sk_lookup_enabled'
> >
> > This is because without CONFIG_INET bpf_sk_lookup_enabled symbol is not
> > available. Wrap references to bpf_sk_lookup_enabled with preprocessor
> > conditionals.
> >
> > Fixes: 1559b4aa1db4 ("inet: Run SK_LOOKUP BPF program on socket lookup")
> > Reported-by: Randy Dunlap <rdunlap@...radead.org>
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
>
> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Applied. Thanks