netdev - Re: [PATCH v3 net-next 04/16] sfc_ef100: skeleton EF100 PF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200721094535.15df7245@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 21 Jul 2020 09:45:35 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        kernel test robot <lkp@...el.com>, <kbuild-all@...ts.01.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net-next 04/16] sfc_ef100: skeleton EF100 PF driver

On Tue, 21 Jul 2020 15:48:00 +0100 Edward Cree wrote:
> Aaaaargh; does anyone have any bright ideas?

No bright ideas. Why do you want the driver to be modular in the first
place? This is a high performance adapter, not a embedded system. Does
this ~1MB of memory use really matter? Folks who care can rebuild their
kernel and disable the device support with a boolean flag.

Maybe I'm wrong, but I've never seen a reason to break up vendor drivers
for high performance NICs into multiple modules.