netdev - Re: [PATCH] sis: switch from 'pci_' to 'dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200720.175039.1939570240770666966.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 17:50:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     kuba@...nel.org, romieu@...zoreil.com, venza@...wnhat.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] sis: switch from 'pci_' to 'dma_' API

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Mon, 20 Jul 2020 15:36:09 +0200

> The wrappers in include/linux/pci-dma-compat.h should go away.
> 
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
> 
> 
> When memory is allocated in 'epic_init_one()' (sis190.c), GFP_KERNEL can be
> used because this is a net_device_ops' 'ndo_open' function. This function
> is protected by the rtnl_lock() semaphore. So only a mutex is used and no
> spin_lock is acquired.
> 
> When memory is allocated in 'sis900_probe()' (sis900.c), GFP_KERNEL can be
> used because it is a probe function and no spin_lock is acquired.
 ...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied.