netdev - Re: [PATCH net-next 3/3] dpaa2-eth: add support for TBF offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200721123108.25da923a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 21 Jul 2020 12:31:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] dpaa2-eth: add support for TBF offload

On Tue, 21 Jul 2020 19:38:25 +0300 Ioana Ciornei wrote:
> React to TC_SETUP_QDISC_TBF and configure the egress shaper as
> appropriate with the maximum rate and burst size requested by the user.
> TBF can only be offloaded on DPAA2 when it's the root qdisc, ie it's a
> per port shaper.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Problems that Jesper run into make me wonder if we should always return
-EOPNOTSUPP as an error from drivers from the root Qdisc. Maybe that's
a larger problem, we already have drivers returning other errors.