netdev - Re: [PATCH bpf-next v2 0/5] bpf: compute btf_ids at build time for btf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200721202108.btao7fx3qf3ndd2b@ast-mbp.dhcp.thefacebook.com>
Date:   Tue, 21 Jul 2020 13:21:08 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jiri Olsa <jolsa@...nel.org>, kernel-team@...com
Subject: Re: [PATCH bpf-next v2 0/5] bpf: compute btf_ids at build time for
 btf_iter

On Mon, Jul 20, 2020 at 09:33:58AM -0700, Yonghong Song wrote:
> Commit 5a2798ab32ba
> ("bpf: Add BTF_ID_LIST/BTF_ID/BTF_ID_UNUSED macros")
> implemented a mechanism to compute btf_ids at kernel build
> time which can simplify kernel implementation and reduce
> runtime overhead by removing in-kernel btf_id calculation.
> 
> This patch set tried to use this mechanism to compute
> btf_ids for bpf_skc_to_*() helpers and for btf_id_or_null ctx
> arguments specified during bpf iterator registration.
> Please see individual patch for details.
> 
> Changelogs:
>   v1 -> v2:
>     - v1 ([1]) is only for bpf_skc_to_*() helpers. This version
>       expanded it to cover ctx btf_id_or_null arguments
>     - abandoned the change of "extern u32 name[]" to
>       "static u32 name[]" for BPF_ID_LIST local "name" definition.
>       gcc 9 incurred a compilation error.
> 
>  [1]: https://lore.kernel.org/bpf/20200717184706.3476992-1-yhs@fb.com/T

Applied, Thanks