netdev - Re: [PATCH net-next 00/14] Phylink PCS updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200721.154729.1573922846524745029.davem@davemloft.net>
Date:   Tue, 21 Jul 2020 15:47:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linux@...linux.org.uk
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        ioana.ciornei@....com, alexandru.marginean@....com,
        claudiu.manoil@....com, kuba@...nel.org, michael@...le.cc,
        netdev@...r.kernel.org, olteanv@...il.com, vladimir.oltean@....com
Subject: Re: [PATCH net-next 00/14] Phylink PCS updates

From: Russell King - ARM Linux admin <linux@...linux.org.uk>
Date: Tue, 21 Jul 2020 12:01:52 +0100

> This series updates the rudimentary phylink PCS support with the
> results of the last four months of development of that.  Phylink
> PCS support was initially added back at the end of March, when it
> became clear that the current approach of treating everything at
> the MAC end as being part of the MAC was inadequate.
> 
> However, this rudimentary implementation was fine initially for
> mvneta and similar, but in practice had a fair number of issues,
> particularly when ethtool interfaces were used to change various
> link properties.
> 
> It became apparent that relying on the phylink_config structure for
> the PCS was also bad when it became clear that the same PCS was used
> in DSA drivers as well as in NXPs other offerings, and there was a
> desire to re-use that code.
> 
> It also became apparent that splitting the "configuration" step on
> an interface mode configuration between the MAC and PCS using just
> mac_config() and pcs_config() methods was not sufficient for some
> setups, as the MAC needed to be "taken down" prior to making changes,
> and once all settings were complete, the MAC could only then be
> resumed.
> 
> This series addresses these points, progressing PCS support, and
> has been developed with mvneta and DPAA2 setups, with work on both
> those drivers to prove this approach.  It has been rigorously tested
> with mvneta, as that provides the most flexibility for testing the
> various code paths.
 ...

Series applied, thank you.