lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 21 Jul 2020 15:55:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     geffrey.guo@...wei.com
Cc:     kuba@...nel.org, maheshb@...gle.com, edumazet@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] ipvlan: add the check of ip header checksum

From: guodeqing <geffrey.guo@...wei.com>
Date: Tue, 21 Jul 2020 21:09:22 +0800

> The ip header checksum can be error in the following steps.
 ...
> $ ip netns exec ns1 tc qdisc add dev ip1 root netem corrupt 50%

This is not valid.

The kernel internally already validated the ipv4 header checksum
before forwarding or sending it on egress to the ipvlan device.

The driver can legitimately depend upon this validation.

Besides, as Cong pointed out, so much other code in the ipvlan
driver has read various ipv4 header members such as the addresses
necessary to perform lookups.

Powered by blists - more mailing lists