netdev - Re: [PATCH net-next] tc-testing: Add tdc to kselftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200720.183010.1627184066290103703.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 18:30:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     briana.oursler@...il.com
Cc:     jhs@...atatu.com, mrv@...atatu.com, shuah@...nel.org,
        sbrivio@...hat.com, dcaratti@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tc-testing: Add tdc to kselftests

From: Briana Oursler <briana.oursler@...il.com>
Date: Fri, 17 Jul 2020 14:54:39 -0700

> Add tdc to existing kselftest infrastructure so that it can be run with
> existing kselftests. TDC now generates objects in objdir/kselftest
> without cluttering main objdir, leaves source directory clean, and
> installs correctly in kselftest_install, properly adding itself to
> run_kselftest.sh script.
> 
> Add tc-testing as a target of selftests/Makefile. Create tdc.sh to run
> tdc.py targets with correct arguments. To support single target from
> selftest/Makefile, combine tc-testing/bpf/Makefile and
> tc-testing/Makefile. Move action.c up a directory to tc-testing/.
> 
> Tested with:
>  make O=/tmp/{objdir} TARGETS="tc-testing" kselftest
>  cd /tmp/{objdir}
>  cd kselftest
>  cd tc-testing
>  ./tdc.sh
> 
>  make -C tools/testing/selftests/ TARGETS=tc-testing run_tests
> 
>  make TARGETS="tc-testing" kselftest
>  cd tools/testing/selftests
>  ./kselftest_install.sh /tmp/exampledir
>  My VM doesn't run all the kselftests so I commented out all except my
>  target and net/pmtu.sh then:
>  cd /tmp/exampledir && ./run_kselftest.sh
> 
> Co-developed-by: Davide Caratti <dcaratti@...hat.com>
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>
> Signed-off-by: Briana Oursler <briana.oursler@...il.com>

Applied, but:

> @@ -0,0 +1,6 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +
> +./tdc.py -c actions --nobuildebpf
> +./tdc.py -c qdisc
> +

I had to remove this trailing newline.