netdev - Re: [PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200720.183849.626605331445628040.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 18:38:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     cuibixuan@...wei.com
Cc:     stephen@...workplumber.org, kuba@...nel.org,
        linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, jdmason@...zu.us,
        christophe.jaillet@...adoo.fr, john.wanghui@...wei.com
Subject: Re: [PATCH v2] net: neterion: vxge: reduce stack usage in
 VXGE_COMPLETE_VPATH_TX

From: Bixuan Cui <cuibixuan@...wei.com>
Date: Mon, 20 Jul 2020 09:58:39 +0800

> Fix the warning: [-Werror=-Wframe-larger-than=]
> 
> drivers/net/ethernet/neterion/vxge/vxge-main.c:
> In function'VXGE_COMPLETE_VPATH_TX.isra.37':
> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1:
> warning: the frame size of 1056 bytes is larger than 1024 bytes
> 
> Dropping the NR_SKB_COMPLETED to 16 is appropriate that won't
> have much impact on performance and functionality.
> 
> Signed-off-by: Bixuan Cui <cuibixuan@...wei.com>
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> ---
> v2: Dropping the NR_SKB_COMPLETED to 16.

Applied.