netdev - Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jul 2020 17:31:37 +0200
From:   "Eelco Chaudron" <echaudro@...hat.com>
To:     "Jakub Kicinski" <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, dev@...nvswitch.org,
        pabeni@...hat.com, pshelar@....org
Subject: Re: [PATCH net-next 2/2] net: openvswitch: make masks cache size
 configurable



On 22 Jul 2020, at 17:21, Jakub Kicinski wrote:

> On Wed, 22 Jul 2020 10:27:52 +0200 Eelco Chaudron wrote:
>> This patch makes the masks cache size configurable, or with
>> a size of 0, disable it.
>>
>> Reviewed-by: Paolo Abeni <pabeni@...hat.com>
>> Signed-off-by: Eelco Chaudron <echaudro@...hat.com>
>
> Hi Elco!
>
> This patch adds a bunch of new sparse warnings:
>
> net/openvswitch/flow_table.c:376:23: warning: incorrect type in 
> assignment (different address spaces)
> net/openvswitch/flow_table.c:376:23:    expected struct 
> mask_cache_entry *cache
> net/openvswitch/flow_table.c:376:23:    got void [noderef] __percpu *
> net/openvswitch/flow_table.c:386:25: warning: incorrect type in 
> assignment (different address spaces)
> net/openvswitch/flow_table.c:386:25:    expected struct 
> mask_cache_entry [noderef] __percpu *mask_cache
> net/openvswitch/flow_table.c:386:25:    got struct mask_cache_entry 
> *cache
> net/openvswitch/flow_table.c:411:27: warning: incorrect type in 
> assignment (different address spaces)
> net/openvswitch/flow_table.c:411:27:    expected struct mask_cache 
> [noderef] __rcu *mask_cache
> net/openvswitch/flow_table.c:411:27:    got struct mask_cache *
> net/openvswitch/flow_table.c:440:35: warning: incorrect type in 
> argument 1 (different address spaces)
> net/openvswitch/flow_table.c:440:35:    expected struct mask_cache *mc
> net/openvswitch/flow_table.c:440:35:    got struct mask_cache 
> [noderef] __rcu *mask_cache

Odd, as I’m sure I ran checkpatch :( Will sent an update fixing those!