netdev - Re: [PATCH v5] hv_netvsc: add support for vlans in AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5BFB5D28-3A27-4945-960A-9962064FC2C8@cisco.com>
Date:   Wed, 22 Jul 2020 15:41:39 +0000
From:   "Sriram Krishnan (srirakr2)" <srirakr2@...co.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "Malcolm Bumgardner (mbumgard)" <mbumgard@...co.com>,
        "Umesha G M (ugm)" <ugm@...co.com>,
        "Niranjan M M (nimm)" <nimm@...co.com>,
        "xe-linux-external(mailer list)" <xe-linux-external@...co.com>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] hv_netvsc: add support for vlans in AF_PACKET mode



On 22/07/20, 8:49 PM, "Jakub Kicinski" <kuba@...nel.org> wrote:

    > Please run checkpatch on your submissions:

    > WARNING: Missing a blank line after declarations
    > #76: FILE: drivers/net/hyperv/netvsc_drv.c:614:
    > +     u16 vlan_tci = 0;
    > +     skb_reset_mac_header(skb);
 
    > ERROR: code indent should use tabs where possible
    > #81: FILE: drivers/net/hyperv/netvsc_drv.c:619:
    > + ^I^I^I}$

    Sorry and thanks for that, resubmitted v6 of the patch