netdev - Re: [PATCH bpf-next v4] bpftool: use only nftw for file tree parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPGftE-ZP1eDrk2o5gCTj6d0D+=Kwp09dEM6O8RybTjdpsks6w@mail.gmail.com>
Date:   Tue, 21 Jul 2020 17:20:30 -0700
From:   Tony Ambardar <tony.ambardar@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Alexei Starovoitov <ast@...nel.org>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, Quentin Monnet <quentin@...valent.com>
Subject: Re: [PATCH bpf-next v4] bpftool: use only nftw for file tree parsing

On Tue, 21 Jul 2020 at 14:50, Daniel Borkmann <daniel@...earbox.net> wrote:
>
> On 7/21/20 4:48 AM, Tony Ambardar wrote:
> > The bpftool sources include code to walk file trees, but use multiple
> > frameworks to do so: nftw and fts. While nftw conforms to POSIX/SUSv3 and
> > is widely available, fts is not conformant and less common, especially on
> > non-glibc systems. The inconsistent framework usage hampers maintenance
> > and portability of bpftool, in particular for embedded systems.
> >
> > Standardize code usage by rewriting one fts-based function to use nftw and
> > clean up some related function warnings by extending use of "const char *"
> > arguments. This change helps in building bpftool against musl for OpenWrt.
> >
> > Also fix an unsafe call to dirname() by duplicating the string to pass,
> > since some implementations may directly alter it. The same approach is
> > used in libbpf.c.
> >
> > Signed-off-by: Tony Ambardar <Tony.Ambardar@...il.com>
>
> Lgtm, applied, thanks!

Thank you, and much appreciation to Quentin for helpful review and feedback.

Best regards,
Tony