netdev - Re: [PATCH,v2] ipvlan: add the check of ip header checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKKSOFSvtoFamuG1S1e5qb_WNpEdFgtQ-UtgkfWa0-WxA@mail.gmail.com>
Date:   Wed, 22 Jul 2020 09:29:57 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     guodeqing <geffrey.guo@...wei.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Mahesh Bandewar <maheshb@...gle.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH,v2] ipvlan: add the check of ip header checksum

On Wed, Jul 22, 2020 at 2:23 AM guodeqing <geffrey.guo@...wei.com> wrote:
>
> The ip header checksum can be error in the following steps.
> $ ip netns add ns1
> $ ip link add gw link eth0 type ipvlan
> $ ip addr add 168.16.0.1/24 dev gw
> $ ip link set dev gw up
> $ ip link add ip1 link eth0 type ipvlan
> $ ip link set ip1 netns ns1
> $ ip netns exec ns1 ip link set ip1 up
> $ ip netns exec ns1 ip addr add 168.16.0.2/24 dev ip1
> $ ip netns exec ns1 tc qdisc add dev ip1 root netem corrupt 50%
> $ ip netns exec ns1 ping 168.16.0.1
>
> This is because the netem will modify the packet randomly. the
> corrupted packets should be dropped derectly, otherwise it may
> cause a problem.


And why would ipvlan be so special ?

What about all other drivers ?

My advice : Do not use netem corrupt if you do not want to send
corrupted packets .

>
>
> Here I add the check of ip header checksum and drop the illegal
> packets in l3/l3s mode.
>

This patch makes no sense really.

>
> Signed-off-by: guodeqing <geffrey.guo@...wei.com>
> ---