netdev - Re: [PATCH 05/29] l2tp: cleanup difficult-to-read line breaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200722090617.GA4419@katalix.com>
Date:   Wed, 22 Jul 2020 10:06:18 +0100
From:   Tom Parkin <tparkin@...alix.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 05/29] l2tp: cleanup difficult-to-read line breaks

On  Tue, Jul 21, 2020 at 13:59:38 -0700, Jakub Kicinski wrote:
> On Tue, 21 Jul 2020 18:31:57 +0100 Tom Parkin wrote:
> >  #if IS_ENABLED(CONFIG_IPV6)
> > -		if (info->attrs[L2TP_ATTR_IP6_SADDR] &&
> > -		    info->attrs[L2TP_ATTR_IP6_DADDR]) {
> > -			cfg.local_ip6 = nla_data(
> > -				info->attrs[L2TP_ATTR_IP6_SADDR]);
> > -			cfg.peer_ip6 = nla_data(
> > -				info->attrs[L2TP_ATTR_IP6_DADDR]);
> > -		} else
> > +		if (attrs[L2TP_ATTR_IP6_SADDR] && attrs[L2TP_ATTR_IP6_DADDR]) {
> > +			cfg.local_ip6 = nla_data(attrs[L2TP_ATTR_IP6_SADDR]);
> > +			cfg.peer_ip6 = nla_data(attrs[L2TP_ATTR_IP6_DADDR]);
> > +		} else {
> >  #endif
> 
> This no longer builds. Probably because you added the closing backet
> which wasn't there?
> 
> Please make sure each patch in the submission builds cleanly.

Sorry, this is a rebase snafu; my mistake.  I test-built the complete
patch series of course, but I'll test build each in turn for v2.

> Please split this submission into series of at most 15 patches at a
> time, to make sure reviewers don't get overloaded.

Will do.

> Please CC people who are working on the l2tp code (get_maintainers
> script is your friend).

Ack, thanks.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)