netdev - Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D02BAA42-7BBB-4A65-AA1A-08A770219B8E@cisco.com>
Date:   Wed, 22 Jul 2020 10:44:43 +0000
From:   "Sriram Krishnan (srirakr2)" <srirakr2@...co.com>
To:     Haiyang Zhang <haiyangz@...rosoft.com>,
        David Miller <davem@...emloft.net>
CC:     KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "Malcolm Bumgardner (mbumgard)" <mbumgard@...co.com>,
        "Umesha G M (ugm)" <ugm@...co.com>,
        "Niranjan M M (nimm)" <nimm@...co.com>,
        "xe-linux-external(mailer list)" <xe-linux-external@...co.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

    On 22/07/20, 3:48 AM, "Haiyang Zhang" <haiyangz@...rosoft.com> wrote:
    > If you make this change, did you see any drop in a live test? The
    > "packet->total_bytes" in struct hv_netvsc_packet  is for book keeping
    > only, which is used for stats info, and not visible by the host at all.

    > I made this suggestion because the "regular" vlan packet length was
    > counted by bytes without the VLAN_HLEN(4) -- the vlan tag is
    > in the skb metadata, separately from the ethernet header. I want the
    > statistical data for AF_PACKET mode consistent with the regular case.

    > struct hv_netvsc_packet {
    >         /* Bookkeeping stuff */
    >         u8 cp_partial; /* partial copy into send buffer */

    >         u8 rmsg_size; /* RNDIS header and PPI size */
    >         u8 rmsg_pgcnt; /* page count of RNDIS header and PPI */
    >         u8 page_buf_cnt;

    >         u16 q_idx;
    >         u16 total_packets;

    >         u32 total_bytes;
    >         u32 send_buf_index;
    >         u32 total_data_buflen;
    > };
        
    > Thanks
    > - Haiyang

    Sorry my bad, found out that the drop was a testbed issue and not related to the change. Patch v5 contains the recommendation.

    Thanks,
    Sriram