lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 23 Jul 2020 12:28:08 +0200
From:   Richard Sailer <richard_siegfried@...temli.org>
To:     David Miller <davem@...emloft.net>
Cc:     gerrit@....abdn.ac.uk, dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5] net: dccp: Add SIOCOUTQ IOCTL support (send
 buffer fill)


> 
> Applied, but I wonder if you'll also need something like tcp's SIOCOUTQNSD?
> 
A good question. SIOCOUTQNSD is not mentioned in man 7 tcp and I didn't
know and consider it. Now that I looked it up (bytes of unsent packets
in send buffer) maybe this patch's ioctl should be renamed SIOCOUTQNSD,
since it returns the byte count of unsent packets.

I'm undecided here, this is also the only of these ioctl's that makes
sense for DCCP since DCCP does not keep sent but un-acked packets so
SIOCOUTQ does not exist for DCCP. Or SIOCOUTQ and SIOCOUTQNSD are the
same for DCCP, that's a viewpoint question. And it's anyhow correctly
documented in dccp.rst, it's about unsent packets.

So I'm undecided here, should I resend my patch renamed to SIOCOUTQNSD?

-- Richard



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists