netdev - RE: [net-next v4 06/15] iecm: Implement mailbox functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW3PR11MB45221A2D18E5FF5D30396F348F760@MW3PR11MB4522.namprd11.prod.outlook.com>
Date:   Thu, 23 Jul 2020 00:47:28 +0000
From:   "Brady, Alan" <alan.brady@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "Michael, Alice" <alice.michael@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "Burra, Phani R" <phani.r.burra@...el.com>,
        "Hay, Joshua A" <joshua.a.hay@...el.com>,
        "Chittim, Madhu" <madhu.chittim@...el.com>,
        "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>,
        "Skidmore, Donald C" <donald.c.skidmore@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
Subject: RE: [net-next v4 06/15] iecm: Implement mailbox functionality

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Tuesday, July 21, 2020 11:01 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: davem@...emloft.net; Michael, Alice <alice.michael@...el.com>;
> netdev@...r.kernel.org; nhorman@...hat.com; sassmann@...hat.com;
> Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; Brady, Alan
> <alan.brady@...el.com>; Burra, Phani R <phani.r.burra@...el.com>; Hay,
> Joshua A <joshua.a.hay@...el.com>; Chittim, Madhu
> <madhu.chittim@...el.com>; Linga, Pavan Kumar
> <pavan.kumar.linga@...el.com>; Skidmore, Donald C
> <donald.c.skidmore@...el.com>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; Samudrala, Sridhar
> <sridhar.samudrala@...el.com>
> Subject: Re: [net-next v4 06/15] iecm: Implement mailbox functionality
> 
> On Mon, 20 Jul 2020 17:38:01 -0700 Tony Nguyen wrote:
> > @@ -30,7 +38,32 @@ static enum iecm_status iecm_ctlq_init_regs(struct
> iecm_hw *hw,
> >  					    struct iecm_ctlq_info *cq,
> >  					    bool is_rxq)
> >  {
> > -	/* stub */
> > +	u32 reg = 0;
> > +
> > +	if (is_rxq)
> > +		/* Update tail to post pre-allocated buffers for Rx queues */
> > +		wr32(hw, cq->reg.tail, (u32)(cq->ring_size - 1));
> > +	else
> > +		wr32(hw, cq->reg.tail, 0);
> > +
> > +	/* For non-Mailbox control queues only TAIL need to be set */
> > +	if (cq->q_id != -1)
> > +		return 0;
> > +
> > +	/* Clear Head for both send or receive */
> > +	wr32(hw, cq->reg.head, 0);
> > +
> > +	/* set starting point */
> > +	wr32(hw, cq->reg.bal, IECM_LO_DWORD(cq->desc_ring.pa));
> > +	wr32(hw, cq->reg.bah, IECM_HI_DWORD(cq->desc_ring.pa));
> > +	wr32(hw, cq->reg.len, (cq->ring_size | cq->reg.len_ena_mask));
> > +
> > +	/* Check one register to verify that config was applied */
> > +	reg = rd32(hw, cq->reg.bah);
> > +	if (reg != IECM_HI_DWORD(cq->desc_ring.pa))
> > +		return IECM_ERR_CTLQ_ERROR;
> 
> Please stop using your own error codes.
> 

We did drastically reduce the amount enum idpf_status usage, but if still not quite satisfactory, we will try and go further with it.

Alan