netdev - Re: [Patch net] geneve: fix an uninitialized value in geneve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200723123943.GH3939726@bistromath.localdomain>
Date:   Thu, 23 Jul 2020 14:39:43 +0200
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org,
        syzbot+7ebc2e088af5e4c0c9fa@...kaller.appspotmail.com
Subject: Re: [Patch net] geneve: fix an uninitialized value in
 geneve_changelink()

2020-07-22, 18:56:25 -0700, Cong Wang wrote:
> geneve_nl2info() sets 'df' conditionally, so we have to
> initialize it by copying the value from existing geneve
> device in geneve_changelink().
> 
> Fixes: 56c09de347e4 ("geneve: allow changing DF behavior after creation")
> Reported-by: syzbot+7ebc2e088af5e4c0c9fa@...kaller.appspotmail.com
> Cc: Sabrina Dubroca <sd@...asysnail.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Ouch. Thanks for fixing this.

Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>

This should only be needed in net/stable. In net-next, I removed this
in commit 9e06e8596bc8 (which will conflict with this patch).

-- 
Sabrina