netdev - Re: [PATCH v2 bpf-next 6/9] bpf: tcp: Allow bpf prog to write and parse TCP header option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200723092936.615fdae7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 23 Jul 2020 09:29:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Martin KaFai Lau <kafai@...com>
Cc:     <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Eric Dumazet <edumazet@...gle.com>, <kernel-team@...com>,
        Lawrence Brakmo <brakmo@...com>,
        Neal Cardwell <ncardwell@...gle.com>, <netdev@...r.kernel.org>,
        Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH v2 bpf-next 6/9] bpf: tcp: Allow bpf prog to write and
 parse TCP header option

On Wed, 22 Jul 2020 18:04:12 -0700 Martin KaFai Lau wrote:
> @@ -3345,6 +3489,7 @@ int tcp_send_synack(struct sock *sk)
>   */
>  struct sk_buff *tcp_make_synack(const struct sock *sk, struct dst_entry *dst,
>  				struct request_sock *req,
> +				struct sk_buff *syn_skb,
>  				struct tcp_fastopen_cookie *foc,
>  				enum tcp_synack_type synack_type)
>  {

Kdoc missing for this one.

While at it would you mind putting an @ before the other ones?