netdev - Re: [PATCH v2 0/8] Hirschmann Hellcreek DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200723093339.7f2b6e27@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 23 Jul 2020 09:33:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kurt Kanzenbach <kurt@...utronix.de>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Richard Cochran <richardcochran@...il.com>,
        Kamil Alkhouri <kamil.alkhouri@...offenburg.de>,
        ilias.apalodimas@...aro.org, Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH v2 0/8] Hirschmann Hellcreek DSA driver

On Thu, 23 Jul 2020 10:17:06 +0200 Kurt Kanzenbach wrote:
> Hi,
> 
> this series adds a DSA driver for the Hirschmann Hellcreek TSN switch
> IP. Characteristics of that IP:
> 
>  * Full duplex Ethernet interface at 100/1000 Mbps on three ports
>  * IEEE 802.1Q-compliant Ethernet Switch
>  * IEEE 802.1Qbv Time-Aware scheduling support
>  * IEEE 1588 and IEEE 802.1AS support
> 
> That IP is used e.g. in
> 
>  https://www.arrow.com/en/campaigns/arrow-kairos
> 
> Due to the hardware setup the switch driver is implemented using DSA. A special
> tagging protocol is leveraged. Furthermore, this driver supports PTP, hardware
> timestamping and TAPRIO offloading.
> 
> This work is part of the AccessTSN project: https://www.accesstsn.com/
> 
> The previous versions can be found here:
> 
>  * https://lkml.kernel.org/netdev/20200618064029.32168-1-kurt@linutronix.de/
>  * https://lkml.kernel.org/netdev/20200710113611.3398-1-kurt@linutronix.de/
> 
> This series depends on:
> 
>  * https://lkml.kernel.org/netdev/20200723074946.14253-1-kurt@linutronix.de/
> 
> Changes since v1:
> 
>  * Code simplifications (Florian Fainelli, Vladimir Oltean)
>  * Fix issues with hellcreek.yaml bindings (Florian Fainelli)
>  * Clear reserved field in ptp v2 event messages (Richard Cochran)
>  * Make use of generic ptp parsing function (Richard Cochran, Vladimir Oltean)
>  * Fix Kconfig (Florian Fainelli)
>  * Add tags (Florian Fainelli, Rob Herring, Richard Cochran) 
> 
> I didn't change the bridge/tagging setup, as I didn't find a better way to do it.

Appears not to build:

drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c: In function ‘hellcreek_get_reserved_field’:
drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c:177:24: error: invalid use of undefined type ‘const struct ptp_header’
  177 |  return be32_to_cpu(hdr->reserved2);
      |                        ^~