netdev - Re: [PATCH net-next 0/6] l2tp: further checkpatch.pl cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5546fc8d-4c5e-c009-455d-4349833fd8c5@katalix.com>
Date:   Thu, 23 Jul 2020 19:00:02 +0100
From:   James Chapman <jchapman@...alix.com>
To:     Tom Parkin <tparkin@...alix.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/6] l2tp: further checkpatch.pl cleanups

On 23/07/2020 12:29, Tom Parkin wrote:
> l2tp hasn't been kept up to date with the static analysis checks offered
> by checkpatch.pl.
>
> This patchset builds on the series "l2tp: cleanup checkpatch.pl
> warnings".  It includes small refactoring changes which improve code
> quality and resolve a subset of the checkpatch warnings for the l2tp
> codebase.
>
> Tom Parkin (6):
>   l2tp: cleanup comparisons to NULL
>   l2tp: cleanup unnecessary braces in if statements
>   l2tp: check socket address type in l2tp_dfs_seq_tunnel_show
>   l2tp: cleanup netlink send of tunnel address information
>   l2tp: cleanup netlink tunnel create address handling
>   l2tp: cleanup kzalloc calls
>
>  net/l2tp/l2tp_core.c    |  30 +++---
>  net/l2tp/l2tp_debugfs.c |  20 ++--
>  net/l2tp/l2tp_ip.c      |   2 +-
>  net/l2tp/l2tp_ip6.c     |   2 +-
>  net/l2tp/l2tp_netlink.c | 206 ++++++++++++++++++++++------------------
>  net/l2tp/l2tp_ppp.c     |  59 ++++++------
>  6 files changed, 169 insertions(+), 150 deletions(-)
>
Reviewed-by: James Chapman <jchapman@...alix.com>