netdev - Re: [PATCH net-next v2] sfc: convert to new udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200723.113630.349385359255054401.davem@davemloft.net>
Date:   Thu, 23 Jul 2020 11:36:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-net-drivers@...arflare.com, mhabets@...arflare.com,
        mslattery@...arflare.com
Subject: Re: [PATCH net-next v2] sfc: convert to new udp_tunnel
 infrastructure

From: Edward Cree <ecree@...arflare.com>
Date: Thu, 23 Jul 2020 10:47:01 +0100

> On 22/07/2020 20:05, Jakub Kicinski wrote:
>> Check MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_TRUSTED, before setting
>> the info, which will hopefully protect us from -EPERM errors
>> the previous code was gracefully ignoring. Ed reports this
>> is not the 100% correct bit, but it's the best approximation
>> we have. Shared code reports the port information back to user
>> space, so we really want to know what was added and what failed.
>> Ignoring -EPERM is not an option.
>>
>> The driver does not call udp_tunnel_get_rx_info(), so its own
>> management of table state is not really all that problematic,
>> we can leave it be. This allows the driver to continue with its
>> copious table syncing, and matching the ports to TX frames,
>> which it will reportedly do one day.
>>
>> Leave the feature checking in the callbacks, as the device may
>> remove the capabilities on reset.
>>
>> Inline the loop from __efx_ef10_udp_tnl_lookup_port() into
>> efx_ef10_udp_tnl_has_port(), since it's the only caller now.
>>
>> With new infra this driver gains port replace - when space frees
>> up in a full table a new port will be selected for offload.
>> Plus efx will no longer sleep in an atomic context.
>>
>> v2:
>>  - amend the commit message about TRUSTED not being 100%
>>  - add TUNNEL_ENCAP_UDP_PORT_ENTRY_INVALID to mark unsed
>>    entries
>>
>> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Looks reasonable enough, have an
> Acked-By: Edward Cree <ecree@...arflare.com>

Applied, thanks everyone.