netdev - Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200723.121345.1943051054532406842.davem@davemloft.net>
Date:   Thu, 23 Jul 2020 12:13:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sundeep.lkml@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org, sgoutham@...vell.com,
        sbhatta@...vell.com
Subject: Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

From: sundeep subbaraya <sundeep.lkml@...il.com>
Date: Thu, 23 Jul 2020 20:29:03 +0530

> Hi David,
> 
> On Wed, Jul 22, 2020 at 7:34 PM sundeep subbaraya
> <sundeep.lkml@...il.com> wrote:
>>
>> Hi David,
>>
>> On Wed, Jul 22, 2020 at 4:47 AM David Miller <davem@...emloft.net> wrote:
>> >
>> > From: sundeep.lkml@...il.com
>> > Date: Tue, 21 Jul 2020 22:44:05 +0530
>> >
>> > > Subbaraya Sundeep (3):
>> > >   octeontx2-pf: Fix reset_task bugs
>> > >   octeontx2-pf: cancel reset_task work
>> > >   octeontx2-pf: Unregister netdev at driver remove
>> >
>> > I think you should shut down all the interrupts and other state
>> > before unregistering the vf network device.
>>
>> Okay will change it and send v2.
>>
> 
> For our case interrupts need to be ON when unregister_netdev is called.
> If driver remove is called when the interface is up then
> otx2_stop(called by unregister_netdev)
> needs mailbox interrupts to communicate with PF to release its resources.

If you leave interrupts on then an interrupt can arrive after the software
state has been released by unregister_netdev.

Sounds like you need to resolve this some other way.