netdev - Re: [PATCH v2] cxgb4: add missing release on skb in uld

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jul 2020 18:14:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     navid.emamdoost@...il.com
Cc:     vishal@...lsio.com, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, emamd001@....edu
Subject: Re: [PATCH v2] cxgb4: add missing release on skb in uld_send()

From: Navid Emamdoost <navid.emamdoost@...il.com>
Date: Wed, 22 Jul 2020 13:57:21 -0500

> In the implementation of uld_send(), the skb is consumed on all
> execution paths except one. Release skb when returning NET_XMIT_DROP.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
> ---
> changes in v2:
> 	- using kfree_skb() based on David Miller suggestion.

This doesn't apply to any of my networking GIT trees.

Please base this on either 'net' or 'net-next' as appropriate,
and indicate this in your Subject line f.e. "[PATCH net v2] ..."

Thank you.