netdev - Re: [PATCH bpf-next v2 01/13] bpf: refactor bpf_iter_reg to have separate seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3300d901-122d-3954-ef51-ea7b6df8ee48@fb.com>
Date:   Wed, 22 Jul 2020 22:43:36 -0700
From:   Yonghong Song <yhs@...com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
CC:     <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, <kernel-team@...com>,
        Martin KaFai Lau <kafai@...com>
Subject: Re: [PATCH bpf-next v2 01/13] bpf: refactor bpf_iter_reg to have
 separate seq_info member



On 7/22/20 10:38 PM, Alexei Starovoitov wrote:
> On Wed, Jul 22, 2020 at 11:49:45AM -0700, Yonghong Song wrote:
>> diff --git a/kernel/bpf/map_iter.c b/kernel/bpf/map_iter.c
>> index 8a7af11b411f..5812dd465c49 100644
>> --- a/kernel/bpf/map_iter.c
>> +++ b/kernel/bpf/map_iter.c
>> @@ -85,17 +85,21 @@ static const struct seq_operations bpf_map_seq_ops = {
>>   BTF_ID_LIST(btf_bpf_map_id)
>>   BTF_ID(struct, bpf_map)
>>   
>> -static struct bpf_iter_reg bpf_map_reg_info = {
>> -	.target			= "bpf_map",
>> +static const struct bpf_iter_seq_info bpf_map_seq_info = {
>>   	.seq_ops		= &bpf_map_seq_ops,
>>   	.init_seq_private	= NULL,
>>   	.fini_seq_private	= NULL,
>>   	.seq_priv_size		= sizeof(struct bpf_iter_seq_map_info),
>> +};
>> +
>> +static struct bpf_iter_reg bpf_map_reg_info = {
>> +	.target			= "bpf_map",
>>   	.ctx_arg_info_size	= 1,
>>   	.ctx_arg_info		= {
>>   		{ offsetof(struct bpf_iter__bpf_map, map),
>>   		  PTR_TO_BTF_ID_OR_NULL },
>>   	},
>> +	.seq_info		= &bpf_map_seq_info,
>>   };
> 
> ahh. this patch needs one more rebase, since I've just added prog_iter.
> Could you please respin ? Thanks!

Sure. Will respin.