netdev - Re: [PATCH v5 net-next 2/5] net: cdc_ether: export usbnet_cdc_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2B227F47-F76D-45EF-85D6-8A5A85AE19A1@mork.no>
Date:   Fri, 24 Jul 2020 16:18:08 +0200
From:   Bjørn Mork <bjorn@...k.no>
To:     Oliver Neukum <oneukum@...e.de>, netdev@...r.kernel.org
CC:     linux-usb@...r.kernel.org, wxcafe@...afe.net,
        Miguel	Rodríguez Pérez 
        <miguel@....uvigo.gal>
Subject: Re: [PATCH v5 net-next 2/5] net: cdc_ether: export usbnet_cdc_update_filter



On July 21, 2020 11:00:08 AM GMT+02:00, Oliver Neukum <oneukum@...e.de> wrote:
>Am Mittwoch, den 15.07.2020, 20:40 +0200 schrieb Bjørn Mork:
>> 
>> @@ -90,6 +90,7 @@ static void usbnet_cdc_update_filter(struct usbnet
>*dev)
>>  			USB_CTRL_SET_TIMEOUT
>>  		);
>>  }
>> +EXPORT_SYMBOL_GPL(usbnet_cdc_update_filter);
>
>Hi,
>
>this function is pretty primitive. In fact it more or less
>is a straight take from the spec. Can this justify the _GPL
>version?

Maybe not? I must admit I didn't put much thought into it. 

I will not object to changing it. And you're the boss anyway :-)


Bjørn