netdev - Re: [RFT iproute2] iplink_bridge: scale all time values by USER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Jul 2020 12:05:13 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     nikolay@...ulusnetworks.com
Cc:     George Shuklin <amarao@...vers.com>, netdev@...r.kernel.org,
        jiri@...nulli.us
Subject: Re: [RFT iproute2] iplink_bridge: scale all time values by USER_HZ

On Fri, 24 Jul 2020 19:24:35 +0300
nikolay@...ulusnetworks.com wrote:

> On 24 July 2020 19:15:17 EEST, Stephen Hemminger <stephen@...workplumber.org> wrote:
> >
> >The bridge portion of ip command was not scaling so the
> >values were off.
> >
> >The netlink API's for setting and reading timers all conform
> >to the kernel standard of scaling the values by USER_HZ (100).
> >
> >Fixes: 28d84b429e4e ("add bridge master device support")
> >Fixes: 7f3d55922645 ("iplink: bridge: add support for
> >IFLA_BR_MCAST_MEMBERSHIP_INTVL")
> >Fixes: 10082a253fb2 ("iplink: bridge: add support for
> >IFLA_BR_MCAST_LAST_MEMBER_INTVL")
> >Fixes: 1f2244b851dd ("iplink: bridge: add support for
> >IFLA_BR_MCAST_QUERIER_INTVL")
> >Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> >---  
> 
> While I agree this should have been done from the start, it's too late to change. 
> We'll break everyone using these commands. 
> We have been discussing to add _ms version of all these which do the proper scaling. I'd prefer that, it's least disruptive
> to users. 
> 
> Every user of the old commands scales the values by now.

So bridge is inconsistent with all other api's in iproute2!
And the bridge option in ip link is scaled differently than the bridge-utils or sysfs.

Maybe an environment variable?
Or add new fixed syntax option and don't show the old syntax?