netdev - Re: [PATCH net-next 3/3] icmp6: support rfc 4884

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Jul 2020 10:25:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next 3/3] icmp6: support rfc 4884

Hi Willem,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Willem-de-Bruijn/icmp6-support-rfc-4884/20200723-223533
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7fc3b978a8971305d456b32d3f2ac13191f5a0d7
config: nios2-defconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/ipv6/datagram.c:288:6: warning: no previous prototype for 'ipv6_icmp_error_rfc4884' [-Wmissing-prototypes]
     288 | void ipv6_icmp_error_rfc4884(const struct sk_buff *skb,
         |      ^~~~~~~~~~~~~~~~~~~~~~~

vim +/ipv6_icmp_error_rfc4884 +288 net/ipv6/datagram.c

   287	
 > 288	void ipv6_icmp_error_rfc4884(const struct sk_buff *skb,
   289				     struct sock_ee_data_rfc4884 *out)
   290	{
   291		switch (icmp6_hdr(skb)->icmp6_type) {
   292		case ICMPV6_TIME_EXCEED:
   293		case ICMPV6_DEST_UNREACH:
   294			ip_icmp_error_rfc4884(skb, out, sizeof(struct icmp6hdr),
   295					      icmp6_hdr(skb)->icmp6_datagram_len * 8);
   296		}
   297	}
   298	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (10817 bytes)