netdev - Re: [PATCH v4 net-next 09/16] sfc_ef100: implement ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202007250522.Sj571vEA%lkp@intel.com>
Date:   Sat, 25 Jul 2020 05:54:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Edward Cree <ecree@...arflare.com>,
        linux-net-drivers@...arflare.com, davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org
Subject: Re: [PATCH v4 net-next 09/16] sfc_ef100: implement ndo_open/close
 and EVQ probing

Hi Edward,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Edward-Cree/sfc-driver-for-EF100-family-NICs-part-1/20200725-000401
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 1b6687e31a2df9fbdb12d25c1d1d372777bf96a8
config: microblaze-randconfig-r021-20200725 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/sfc/ef100_nic.c:280:16: error: 'ef100_enqueue_skb' undeclared here (not in a function); did you mean 'efx_enqueue_skb_tso'?
     280 |  .tx_enqueue = ef100_enqueue_skb,
         |                ^~~~~~~~~~~~~~~~~
         |                efx_enqueue_skb_tso
>> drivers/net/ethernet/sfc/ef100_nic.c:285:15: error: '__ef100_rx_packet' undeclared here (not in a function)
     285 |  .rx_packet = __ef100_rx_packet,
         |               ^~~~~~~~~~~~~~~~~

vim +280 drivers/net/ethernet/sfc/ef100_nic.c

   247	
   248	/*	NIC level access functions
   249	 */
   250	const struct efx_nic_type ef100_pf_nic_type = {
   251		.revision = EFX_REV_EF100,
   252		.is_vf = false,
   253		.probe = ef100_probe_pf,
   254		.mcdi_max_ver = 2,
   255		.mcdi_request = ef100_mcdi_request,
   256		.mcdi_poll_response = ef100_mcdi_poll_response,
   257		.mcdi_read_response = ef100_mcdi_read_response,
   258		.mcdi_poll_reboot = ef100_mcdi_poll_reboot,
   259		.mcdi_reboot_detected = ef100_mcdi_reboot_detected,
   260		.irq_enable_master = efx_port_dummy_op_void,
   261		.irq_disable_non_ev = efx_port_dummy_op_void,
   262		.push_irq_moderation = efx_channel_dummy_op_void,
   263		.min_interrupt_mode = EFX_INT_MODE_MSIX,
   264		.map_reset_reason = ef100_map_reset_reason,
   265		.map_reset_flags = ef100_map_reset_flags,
   266		.reset = ef100_reset,
   267	
   268		.check_caps = ef100_check_caps,
   269	
   270		.ev_probe = ef100_ev_probe,
   271		.ev_init = ef100_ev_init,
   272		.ev_fini = efx_mcdi_ev_fini,
   273		.ev_remove = efx_mcdi_ev_remove,
   274		.irq_handle_msi = ef100_msi_interrupt,
   275		.ev_process = ef100_ev_process,
   276		.ev_read_ack = ef100_ev_read_ack,
   277		.tx_probe = ef100_tx_probe,
   278		.tx_init = ef100_tx_init,
   279		.tx_write = ef100_tx_write,
 > 280		.tx_enqueue = ef100_enqueue_skb,
   281		.rx_probe = efx_mcdi_rx_probe,
   282		.rx_init = efx_mcdi_rx_init,
   283		.rx_remove = efx_mcdi_rx_remove,
   284		.rx_write = ef100_rx_write,
 > 285		.rx_packet = __ef100_rx_packet,
   286	
   287		/* Per-type bar/size configuration not used on ef100. Location of
   288		 * registers is defined by extended capabilities.
   289		 */
   290		.mem_bar = NULL,
   291		.mem_map_size = NULL,
   292	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25382 bytes)