netdev - Re: 答复: [PATCH,v2] ipvlan: add the check of ip header checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Jul 2020 16:44:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     geffrey.guo@...wei.com
Cc:     edumazet@...gle.com, kuba@...nel.org, maheshb@...gle.com,
        netdev@...r.kernel.org
Subject: Re: 答复: [PATCH,v2] ipvlan: add the check of
 ip header checksum

From: "Guodeqing (A)" <geffrey.guo@...wei.com>
Date: Fri, 24 Jul 2020 03:35:02 +0000

> The ihl check maybe not suitable in ip_fast_csum, the correct of the
> ihl value can be checked before calling the ip_fast_csum.

ip_fast_csum() must be able to handle any value that could fit in the
ihl field of the ip protocol header.  That's not only the most correct
logic, but also the most robust.

> The implementation of ip_fast_csum is different in different cpu
> architecture. the IP packet will do ip forward in the ipvlan l3/l3s
> mode and the corrupted ip packet

As Eric explained, several times, ip_fast_csum on arm64 has a bug and that
is where the fix belongs.

Please fix this bug in the proper place.

Thank you.