netdev - [Patch net] qrtr: orphan skb before queuing in xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 Jul 2020 21:50:40 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     netdev@...r.kernel.org
Cc:     Cong Wang <xiyou.wangcong@...il.com>,
        syzbot+6720d64f31c081c2f708@...kaller.appspotmail.com,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: [Patch net] qrtr: orphan skb before queuing in xmit

Similar to tun_net_xmit(), we have to orphan the skb
before queuing it, otherwise we may use the socket when
purging the queue after it is freed by user-space.

Reported-and-tested-by: syzbot+6720d64f31c081c2f708@...kaller.appspotmail.com
Fixes: 28fb4e59a47d ("net: qrtr: Expose tunneling endpoint to user space")
Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
---
 net/qrtr/tun.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/qrtr/tun.c b/net/qrtr/tun.c
index 15ce9b642b25..54a565dcfef3 100644
--- a/net/qrtr/tun.c
+++ b/net/qrtr/tun.c
@@ -20,6 +20,7 @@ static int qrtr_tun_send(struct qrtr_endpoint *ep, struct sk_buff *skb)
 {
 	struct qrtr_tun *tun = container_of(ep, struct qrtr_tun, ep);
 
+	skb_orphan(skb);
 	skb_queue_tail(&tun->queue, skb);
 
 	/* wake up any blocking processes, waiting for new data */
-- 
2.27.0