netdev - Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1595567665.24550.0.camel@realtek.com>
Date:   Fri, 24 Jul 2020 05:14:25 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path

On Thu, 2020-07-23 at 17:32 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variables ant_num and single_ant_path are being initialized with a
> value that is never read and are being updated later with a new value.
> The initializations are redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

Thank you

> ---
>  drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> index a4940a3842de..4949f99844b5 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -1318,7 +1318,7 @@ bool exhalbtc_bind_bt_coex_withadapter(void *adapter)
>  {
>  	struct rtl_priv *rtlpriv = adapter;
>  	struct btc_coexist *btcoexist = rtl_btc_coexist(rtlpriv);
> -	u8 ant_num = 2, chip_type, single_ant_path = 0;
> +	u8 ant_num, chip_type, single_ant_path;
>  
>  	if (!btcoexist)
>  		return false;