netdev - Re: [PATCH net-next] mscc: Add LCPLL Reset to VSC8574 Family of phy drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Jul 2020 14:02:29 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bryan Whitehead <Bryan.Whitehead@...rochip.com>,
        davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next] mscc: Add LCPLL Reset to VSC8574 Family of phy
 drivers

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Bryan-Whitehead/mscc-Add-LCPLL-Reset-to-VSC8574-Family-of-phy-drivers/20200724-043103
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 15be4ea3f07034a50eee2db6f3fefd2bec582170
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/phy/mscc/mscc_main.c: In function 'vsc8574_reset_lcpll':
>> drivers/net/phy/mscc/mscc_main.c:953:6: warning: variable 'reg_val' set but not used [-Wunused-but-set-variable]
     953 |  u16 reg_val = 0;
         |      ^~~~~~~

vim +/reg_val +953 drivers/net/phy/mscc/mscc_main.c

   949	
   950	/* bus->mdio_lock should be locked when using this function */
   951	static int vsc8574_reset_lcpll(struct phy_device *phydev)
   952	{
 > 953		u16 reg_val = 0;
   954		int ret = 0;
   955	
   956		phy_base_write(phydev, MSCC_EXT_PAGE_ACCESS,
   957			       MSCC_PHY_PAGE_EXTENDED_GPIO);
   958	
   959		/* Read LCPLL config vector into PRAM */
   960		phy_base_write(phydev, 18, 0x8023);
   961		ret = vsc8574_wait_for_micro_complete(phydev);
   962		if (ret)
   963			goto done;
   964	
   965		/* Set Address to Poke */
   966		phy_base_write(phydev, 18, 0xd7d5);
   967		ret = vsc8574_wait_for_micro_complete(phydev);
   968		if (ret)
   969			goto done;
   970	
   971		/* Poke to reset PLL Start up State Machine,
   972		 * set disable_fsm:bit 119
   973		 */
   974		phy_base_write(phydev, 18, 0x8d06);
   975		ret = vsc8574_wait_for_micro_complete(phydev);
   976		if (ret)
   977			goto done;
   978	
   979		/* Rewrite PLL config vector */
   980		phy_base_write(phydev, 18, 0x80c0);
   981		ret = vsc8574_wait_for_micro_complete(phydev);
   982		if (ret)
   983			goto done;
   984	
   985		usleep_range(10000, 20000);
   986	
   987		/* Poke to deassert Reset of PLL State Machine,
   988		 * clear disable_fsm:bit 119
   989		 */
   990		phy_base_write(phydev, 18, 0x8506);
   991		ret = vsc8574_wait_for_micro_complete(phydev);
   992		if (ret)
   993			goto done;
   994	
   995		/* Rewrite PLL config vector */
   996		phy_base_write(phydev, 18, 0x80c0);
   997		ret = vsc8574_wait_for_micro_complete(phydev);
   998		if (ret)
   999			goto done;
  1000	
  1001		usleep_range(10000, 20000);
  1002	
  1003		phy_base_write(phydev, MSCC_EXT_PAGE_ACCESS,
  1004			       MSCC_PHY_PAGE_EXTENDED_3);
  1005		reg_val = phy_base_read(phydev, 20);
  1006		reg_val = phy_base_read(phydev, 20);
  1007	
  1008		usleep_range(110000, 200000);
  1009	
  1010	done:
  1011		phy_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD);
  1012		return ret;
  1013	}
  1014	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (61171 bytes)