netdev - Re: [PATCH net-next v3 1/2] hinic: add support to handle hw abnormal event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92dac9af-8623-bd1e-7a4d-9d12671699ad@solarflare.com>
Date:   Fri, 24 Jul 2020 10:57:30 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     David Miller <davem@...emloft.net>, <luobin9@...wei.com>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <luoxianjun@...wei.com>, <yin.yinshi@...wei.com>,
        <cloud.wangxiaoyun@...wei.com>, <chiqijun@...wei.com>
Subject: Re: [PATCH net-next v3 1/2] hinic: add support to handle hw abnormal
 event

On 23/07/2020 20:08, David Miller wrote:
> From: Luo bin <luobin9@...wei.com>
> Date: Thu, 23 Jul 2020 22:40:37 +0800
>
>> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter,
>> +				  struct devlink_fmsg *fmsg, void *priv_ctx,
>> +				  struct netlink_ext_ack *extack)
>> +{
>> +	struct hinic_mgmt_watchdog_info *watchdog_info;
>> +	int err;
>> +
>> +	if (priv_ctx) {
>> +		watchdog_info = priv_ctx;
>> +		err = mgmt_watchdog_report_show(fmsg, watchdog_info);
>> +		if (err)
>> +			return err;
>> +	}
>> +
>> +	return 0;
>> +}
> This 'watchdog_info' variable is completely unnecessary, just pass
> 'priv_ctx' as-is into mgmt_watchdog_report_show().
Looks like the 'err' variable is unnecessary too...

-ed